Re: [PATCH dt-schema] schemas: i2c: Allow '-' in 'i2c-.*' node names

Wolfram Sang <[email protected]> Tue, 20 May 2025 11:25:42 +0200

Newsgroups	org.kernel.vger.devicetree-spec,org.kernel.vger.linux-i2c
Message-ID	<aCxKlniEUCJq-aqu@shikoro>

On Mon, May 19, 2025 at 08:18:53PM -0500, Rob Herring wrote:
> On Mon, May 19, 2025 at 1:45 PM Wolfram Sang
> <[email protected]> wrote:
> >
> > When allowing extended i2c node names, the '-' character was not added
> > to the character class. Fixes the following error:
> >
> > .../Kernel/linux/arch/arm/boot/dts/microchip/usb_a9g20.dtb: i2c-gpio-0 (i2c-gpio): $nodename:0: 'i2c-gpio-0' does not match '^i2c(@.+|-[a-z0-9]+)?$'
> >         from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
> 
> IMO, we should change the node name to "i2c-0". While I'm on the fence
> whether it's worth changing these, I do think it is worth not getting
> new ones.

It is hard changing the existing ones. They are numbered based on the
numbers of GPIO based I2C busses only. If we drop "gpio-", they need to
be mixed with other non-GPIO busses. That numbering is usually unique
per board and can't be automated.

signature.asc (application/pgp-signature, 833 B)