[RFC PATCH 38/77] tests: metadata: Improve sort test to check for import symbols sorting
Herve Codina <[email protected]> Mon, 12 Jan 2026 15:19:28 +0100
| Newsgroups | org.kernel.vger.devicetree-spec,org.kernel.vger.devicetree-compiler,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
dtc is able to sort the import symbols list when the --sort option is used. Improve the metadata sort test to perform a check for this feature. Signed-off-by: Herve Codina <[email protected]> --- tests/metadata_sort.dtb.dts.expect | 4 ++++ tests/metadata_sort.dtb.expect | 3 +++ tests/metadata_sort.dts | 4 ++++ tests/run_tests.sh | 4 ++-- 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/tests/metadata_sort.dtb.dts.expect b/tests/metadata_sort.dtb.dts.expect index f07a42b..270c06d 100644 --- a/tests/metadata_sort.dtb.dts.expect +++ b/tests/metadata_sort.dtb.dts.expect @@ -1,6 +1,10 @@ /dts-v1/; /addon/; +/import/ abc: "foo,bar"; +/import/ de1: "foo,bar"; +/import/ de2: "foo,bar"; + / { node-a { diff --git a/tests/metadata_sort.dtb.expect b/tests/metadata_sort.dtb.expect index 7856894..0dacab7 100644 --- a/tests/metadata_sort.dtb.expect +++ b/tests/metadata_sort.dtb.expect @@ -13,3 +13,6 @@ phandle = <0x00000001>; }; }; +// [FDT_IMPORT_SYM] 'abc' (foo,bar) +// [FDT_IMPORT_SYM] 'de1' (foo,bar) +// [FDT_IMPORT_SYM] 'de2' (foo,bar) diff --git a/tests/metadata_sort.dts b/tests/metadata_sort.dts index 7d1cca7..e523e20 100644 --- a/tests/metadata_sort.dts +++ b/tests/metadata_sort.dts @@ -6,6 +6,10 @@ /dts-v1/; /addon/; +/import/ de1: "foo,bar"; +/import/ abc: "foo,bar"; +/import/ de2: "foo,bar"; + / { node_b: node-b { }; diff --git a/tests/run_tests.sh b/tests/run_tests.sh index 5368db9..a5e31df 100755 --- a/tests/run_tests.sh +++ b/tests/run_tests.sh @@ -1158,8 +1158,8 @@ metadata_tests() { run_dtc_test -I dts -O dtb -s -o metadata_sort.dtb "$SRCDIR/metadata_sort.dts" base_run_test wrap_fdtdump metadata_sort.dtb metadata_sort.dtb.out - # Remove unneeded comments - sed -i '/^\/\/ /d' metadata_sort.dtb.out + # Remove unneeded comments, keep comments in the form '// [xxxx' + sed -i '/^\/\/ [^\[]/d' metadata_sort.dtb.out base_run_test check_diff metadata_sort.dtb.out "$SRCDIR/metadata_sort.dtb.expect" run_dtc_test -I dtb -O dts -o metadata_sort.dtb.dts metadata_sort.dtb base_run_test check_diff metadata_sort.dtb.dts "$SRCDIR/metadata_sort.dtb.dts.expect" -- 2.52.0