Re: [RFC PATCH 04/77] dtc: Allow to use data_append_markers() out of data.c

David Gibson <[email protected]> Thu, 15 Jan 2026 11:18:11 +1100

Newsgroups	org.kernel.vger.devicetree-spec,org.kernel.vger.devicetree-compiler,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<aWgyQ1JcKB6AyHn9@zatzit>

On Mon, Jan 12, 2026 at 03:18:54PM +0100, Herve Codina wrote:
> With meta-data available in dtb, markers can be set as soon as a dtb is
> parsed. This will be done in flattree.c using data_append_markers().
> 
> Prepare this usage allowing this function to be used out of data.c

Trivial enough I'd suggest folding it into the patch that needs to use
data_append_markers() elsewhere.

> 
> Signed-off-by: Herve Codina <[email protected]>
> ---
>  data.c | 2 +-
>  dtc.h  | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/data.c b/data.c
> index 5b25aa0..11b2169 100644
> --- a/data.c
> +++ b/data.c
> @@ -127,7 +127,7 @@ struct data data_insert_at_marker(struct data d, struct marker *m,
>  	return d;
>  }
>  
> -static struct data data_append_markers(struct data d, struct marker *m)
> +struct data data_append_markers(struct data d, struct marker *m)
>  {
>  	struct marker **mp = &d.markers;
>  
> diff --git a/dtc.h b/dtc.h
> index 186caad..3bbd97e 100644
> --- a/dtc.h
> +++ b/dtc.h
> @@ -187,6 +187,7 @@ struct data data_insert_data(struct data d, struct marker *m, struct data old);
>  struct marker *alloc_marker(unsigned int offset, enum markertype type,
>  			    char *ref);
>  struct data data_add_marker(struct data d, enum markertype type, char *ref);
> +struct data data_append_markers(struct data d, struct marker *m);
>  
>  bool data_is_one_string(struct data d);
>  
> -- 
> 2.52.0
> 
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

signature.asc (application/pgp-signature, 833 B)