Re: [RFC PATCH 64/77] dtc: Add support for references by path involving orphan nodes

--xSJeV4ZdgrexttyB
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 19, 2026 at 05:38:31PM +0100, Herve Codina wrote:
> On Thu, 15 Jan 2026 18:01:39 +1100
> David Gibson <[email protected]> wrote:
>=20
> > On Mon, Jan 12, 2026 at 03:19:54PM +0100, Herve Codina wrote:
> > > Referencing a sub-node from an orphan node using a path is needed.
> > >=20
> > > Indeed, using the following snippet:
> > > --- 8< ---
> > > /addon/;
> > >=20
> > > &node1 {
> > > 	subnode {
> > > 		foo-phandle =3D <&foo_label>;
> > > 	};
> > > };
> > >=20
> > > &node2 {
> > > 	foo_label: foo {
> > > 		prop =3D <1>;
> > > 	};
> > > };
> > > --- 8< ---
> > >=20
> > > Even if node2 is an orphan node, foo is a local node. foo-phandle
> > > references the foo node using a label. =20
> >=20
> > Another option would be to eliminate the idea of local references, and
> > require a symbol be attached to things that you want to reference by
> > label.
>=20
> Hum, new kind of references.

No, I'm trying to remove a type of reference: I'm suggesting using the
same format as for external references on local references as well.
That might mean things referenced need to be both exported and
imported by the tree creating them.  That might be worth it to reduce
the number of cases.

> We have reference by phandle to local nodes. Reference by symbol for
> external nodes (i.e. nodes not present in current dtb).
>=20
> Now new kind of reference for node available in the current dtb but
> in a different tree (orphan tree).
>=20
> For that we need to:
>   - Mark the phandle value in the property as a cross-tree phandle
>     reference
>   - Add the symbol label in the referenced node.
>=20
> When the addon is applied, this new kind of reference need to be taken
> into account in a new way:
>   - The phandle value in the referenced node need to be updated in the
>     same way as all other phandle value in nodes to avoid collisions.
>   - The cross-tree reference needs to be resolved.
>=20
> This adds an unneeded complexity.
>=20
> IMHO, we shouldn't eliminate local references.
>=20
> We need to reference all possible local nodes by path even if cross-tree
> due to orphan tree is involved.
>=20
> Best regards,
> Herv=E9
>=20

--=20
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

--xSJeV4ZdgrexttyB
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmlwlvgACgkQzQJF27ox
2Ge0dg//W/TDlG7p0f5PVq5x5rRodgKag2xF8snDWBZey2IBqWk9AfcpiLjNrsfR
focbM1pkcYajLnTRA5AEDiQ1+ycLA3wnESQrb1MuZzkTvE1OLB96PV865HpWXUU4
6IofTNK8uvDVnjfXEjpm7E+gtJaYDyd0MlpzRl5rv9KpxHnsWd5K4wySM+Yy2WdT
V3/jalWMOg0t33ucI2oceYPW7a2coh27m769AadgoP7jWuE6Y/flK3yEgz+EVzkJ
4WFMb7jDUus69j0l35QA2RjuStvcZvCf9mE2uHuQXo/V50pWXtfzu/1Nj1DQHyIK
0oYHNBq46XdZZ3of3dnjxF/L2TYsVg3dFLYl7MGOj3rLWsnz6O5Zg/WjrhF3YBMu
6JHG+8+vlGBDyNb/ls56IdPbX8ioN97coVtyrKrp29c4nHvVSZrmDjfgrwROdVhK
t40xCp9ovFD2OZbixaTf/5C9IPY1Abbu5mwewOz5bD5XXmpD+ge8pwYWi8z4AJQc
8bA2J7gqa4RUGsC0G131OdpqhdLmnX9SmpMxUitT5GvMh3DeewcexuOun1I4BJ5m
2xAzuDspTdABuqMzsZKHOuiL9FFjioTqlxWkryEngBCG4YsOQ8hPSZrmW5X3peZd
HtJxlf/ZHrpriOwKDITdXe+mgeeTvHR5m/8VvJjTKOVwdDzcvIc=
=NkYw
-----END PGP SIGNATURE-----

--xSJeV4ZdgrexttyB--