Re: [RFC PATCH 01/15] dtc: Use a consistent type for basenamelen

--hcXyh80QbaoBzcm6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 10, 2026 at 06:33:29PM +0100, Herve Codina wrote:
> The basenamelen member in the node structure is set in all cases to
> a positive value, the length of the basename string. Also it is used as
> parameters on function expecting a size_t type.
>=20
> Further more an implicit cast of strspn() returned value from size_t to
> int is needed in checks.c to avoid a signed/unsigned compilation warning
> when this value is checked.
>=20
> This member has no reason to be a signed integer and its obvious type is
> size_t.
>=20
> Be consistent and fix its type.
>=20
> Signed-off-by: Herve Codina <[email protected]>

Applied, thanks.

Reviewing the rest of the series may still take a while.

> ---
>  checks.c | 2 +-
>  dtc.h    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/checks.c b/checks.c
> index 45d0213..946c142 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -324,7 +324,7 @@ ERROR(node_name_chars, check_node_name_chars, NODECHA=
RS);
>  static void check_node_name_chars_strict(struct check *c, struct dt_info=
 *dti,
>  					 struct node *node)
>  {
> -	int n =3D strspn(node->name, c->data);
> +	size_t n =3D strspn(node->name, c->data);
> =20
>  	if (n < node->basenamelen)
>  		FAIL(c, dti, node, "Character '%c' not recommended in node name",
> diff --git a/dtc.h b/dtc.h
> index 7231200..473552e 100644
> --- a/dtc.h
> +++ b/dtc.h
> @@ -227,7 +227,7 @@ struct node {
>  	struct node *next_sibling;
> =20
>  	char *fullpath;
> -	int basenamelen;
> +	size_t basenamelen;
> =20
>  	cell_t phandle;
>  	int addr_cells, size_cells;
> --=20
> 2.52.0
>=20
>=20

--=20
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

--hcXyh80QbaoBzcm6
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmOwSAACgkQzQJF27ox
2Gcd1Q//Tvhcgfpf7L6SlfRq3qmgfQeIu7dWNpS2Z0XN/H9lYuklQ3IiP3nrMbBl
69bhbRGhTkPTcMsRdzIiMMAOtoyUwzgMJWG8LdgsLXrglgEuv8bWjjFiP/H4YT/8
yvVsKKRQCFuv6ji00hk7/AZMbtjV3Qh7JoyrkcgE1AtWb5mHdCy809i+ydaB6K+v
uVpoUEbFmoZ7Mk7XmYuuXXHp5oJyhxZ6R7ZX7JFRngE723XD1NN8jlvyng3TVwzy
rufa6Fq2w1WaXuoG/bMj3BmpIAJm5XWm/vHAALhMyMD0hcd9caqN+lD2fCBDJ+hw
V+uH3O7MZPYpR7xHpz3hZtr49ADB3j/31GRQYQfcjZMdUB2Aa9vcgW1vaJYWoif9
DYHW7+sgXFyZypMY21IDAxZyNhDg8hmTaDaVvzcWqh9Ppn0mxzt8nIIfvNnywMne
PRpr8gVxjLuAppGhrey1TzcyA1lwhWNdbYzjTYWZxX7Otz3ZnC10xJbgBYJ+P9s3
Vaf9SFbtzIKLs3i/hQD7oCRMMVZ+blXZMtwULKJjnbJHzo3BuIUcomiHCO7o9xOC
r1Jl1nJ6KVJp3RNMV5zk6IJFgWpXdAd3oT6ziPk66KZLDMQ3YEQlzkMYEkfts6O0
iLcEhcC9dnp6N3UnmzHDFl4bRgksKp4u7ohw6jmNvTz8fQHlJBY=
=fzz+
-----END PGP SIGNATURE-----

--hcXyh80QbaoBzcm6--