Re: [PATCH v7 13/19] dt-bindings: dma: ti: Add K3 BCDMA V2
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.kernel.vger.dmaengine,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260725-acoustic-orchid-tiger-a6be5f@quoll> |
On Fri, Jul 24, 2026 at 03:50:46PM +0530, Sai Sree Kartheek Adivi wrote: > + "#dma-cells": > + const: 4 > + description: | > + cell 1: Trigger type for the channel > + 0 - disable / no trigger > + 1 - internal channel event > + 2 - external signal > + 3 - timer manager event > + > + cell 2: parameter for the trigger: > + if cell 1 is 0 (disable / no trigger): > + Unused, ignored > + if cell 1 is 1 (internal channel event): > + channel number whose TR event should trigger the current channel. > + if cell 1 is 2 or 3 (external signal or timer manager event): > + index of global interfaces that come into the DMA. > + > + Please refer to the device documentation for global interface indexes. > + > + cell 3: Channel ID for the peripheral > + This is the mapped_channel_id assigned to the peripheral in the PSI-L > + endpoint map. For XYMF peripherals (SPI, CRC32) each chip-select/FIFO > + has a distinct channel ID; use the channel ID for the specific > + direction and chip-select being requested. Use 0 for triggered > + block-copy channels (cell 1 != 0). > + > + Please refer to the device documentation for the channel map. > + > + cell 4: ASEL value for the channel > + > + interrupts: > + minItems: 75 You can drop this > + maxItems: 75 > + description: > + Interrupts for DMA channels. > + > + interrupt-names: > + minItems: 75 And this as well, implied by maxItems. With these: Reviewed-by: Krzysztof Kozlowski <[email protected]> Best regards, Krzysztof