Re: [PATCH v3 03/11] dmaengine: switchtec-dma: halt channel on alloc_chan_resources error

Logan Gunthorpe <[email protected]> Mon, 27 Jul 2026 15:28:31 -0600
Newsgroups org.kernel.vger.dmaengine,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-pci
Message-ID <[email protected]>

On 2026-07-27 14:47, Frank Li wrote:
> On Mon, Jul 27, 2026 at 06:51:00PM +0000, [email protected] wrote:
>> Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider:
>>
>> New issues:
>> - [High] Incomplete fix / DMA Use-After-Free due to early return in switchtec_dma_chan_stop() on halt timeout.
>>
> 
> Is it true?

Yes, unfortunately. I'm working on v4 now that fixes this and maybe the
issue Sashiko pointed out in patch 4 as well, but I haven't dug into
that one yet.

Logan