Re: [PATCH RESEND v7 06/10] arm64: dts: qcom: shikra: Enable CDSP, LPAICP and MPSS on EVK boards

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:
- [Medium] The MPSS firmware path for the Shikra IQS EVK board incorrectly =
uses the 'cqs' directory instead of 'iqs', indicating a likely copy-paste e=
rror.
--

--- Patch [6]: [PATCH RESEND v7 06/10] arm64: dts: qcom: shikra: Enable CDS=
P, LPAICP and MPSS on EVK boards ---
commit 650ef0149b380b830878229ce3b6a1cd3b078c37
Author: Bibek Kumar Patro <[email protected]>

arm64: dts: qcom: shikra: Enable CDSP, LPAICP and MPSS on EVK boards

This commit enables the CDSP, LPAICP, and MPSS remote processors for the
Qualcomm Shikra CQM, CQS, and IQS EVK boards. It adds the respective
remoteproc device tree nodes along with their firmware paths.

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts b/arch/arm64/boo=
t/dts/qcom/shikra-iqs-evk.dts
> index 3003a47bd7594..727809430fd15 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts

[ ... ]

> @@ -23,6 +23,25 @@ chosen {
>  	};
>  };
> =20
[ ... ]
> +&remoteproc_mpss {
> +	firmware-name =3D "qcom/shikra/cqs/qdsp6sw.mbn";

[Severity: Medium]
Is this firmware path correct for the IQS board?

It looks like the path points to the 'cqs' directory instead of 'iqs'. Could
this cause the MPSS remote processor to fail to start or load the wrong
firmware on the Shikra IQS EVK?

> +
> +	status =3D "okay";
> +};
> +

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260803-shikra-dt-=
[email protected]?part=3D6