[PATCH v8 00/19] dmaengine: ti: Add support for BCDMA v2 and PKTDMA v2
Sai Sree Kartheek Adivi <[email protected]>
| Newsgroups | org.kernel.vger.dmaengine,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
This series adds support for the BCDMA_V2 and PKTDMA_V2 which is introduced in AM62L. The key differences between the existing DMA and DMA V2 are: - Absence of TISCI: Instead of configuring via TISCI calls, direct register writes are required. - Autopair: There is no longer a need for PSIL pair and instead AUTOPAIR bit needs to set in the RT_CTL register. - Static channel mapping: Each channel is mapped to a single peripheral. - Direct IRQs: There is no INT-A and interrupt lines from DMA are directly connected to GIC. - Remote side configuration handled by DMA. So no need to write to PEER registers to START / STOP / PAUSE / TEARDOWN. - Unified Channel Space: Tx and Rx channels share a single register space. Each channel index is specifically fixed in hardware as either Tx or Rx in an interleaved manner. Full tree with device tree patches can be reviewed at: https://github.com/sskartheekadivi/linux/tree/dma-upstream-v8 Changes from v7 to v8: - Fix issues reported by Sashiko which are introduced by this series https://sashiko.dev/#/patchset/[email protected] - Remove minItems for interrupts entry in both BCDMA and PKTDMA dt-bindings - Update interrupt-names pattern for pktdma from tflow-<n>/rflow-<n> to tx-<n>/rx-<n>. link to v7: https://lore.kernel.org/all/[email protected]/ Changes from v6 to v7: - Rebase to next-20260721 - [03/19]: Add missing includes - Fix incorrect register bits used when configuring rx flows. Add correct UDMA_CHAN_CFG_FILT_EINFO/PSWORDS and UDMA_FLOWRT_RFA_RX_EINFO/PSINFO_PRESENT bit definitions. - Update AM62L BCDMA and PKTDMA dt bindings to remove address cells, redefine dma-cells semantics (mapped channel id for bcdma, hardware flow id for pktdma) and fully enumerate interrupts/interrupt-names with restricted naming patterns. - Add fifo select register write support for XYMF channels in the BCDMA v2 driver. Update udma_v2_filter_param to use channel id instead of remote thread id and resolve it via psil_get_ep_config_by_id(). - Switch channel resource bitmap allocation to devm_bitmap_zalloc() and ring IRQ registration to request_irq()+IRQF_SHARED (channels can now share a PSI-L/IRQ line); fix the ring IRQ handler to return IRQ_NONE for spurious/foreign interrupts instead of unconditionally claiming them. link to v6: https://lore.kernel.org/all/[email protected]/ Changes from v5 to v6: - Switch from interrupt-map to interrupts and interrupt-names in the dt-bindings. - Reverse the if DMA version checks to check for v1 and else v2. - Add new patch [01/19] before refactoring to fix sporadic crash observed on AM62x. link to v5: https://lore.kernel.org/all/[email protected]/ Changes from v4 to v5: - Introduce a new version variable in udma_match_data to differentiate between K3 UDMA V1 and K3 UDMA V2. This simplifies the approach for adding any future possible variants avoiding complex if conditions. - Fix both K3 BCDMA V2 and PKTDMA V2 dt bindings as per the comments from previous versions. - Fix minor nitpicks like following the reverse christmas tree order for variable declarations. - Remove the patch [v4 19/19] that switches to synchronous descriptor freeing. With this patch, dma_free_coherent gets called in irq context and hence a WARN(). link to v4: https://lore.kernel.org/all/[email protected]/ Changes from v3 to v4: - Rename the dt-binding files to add "ti," prefix. - Update cell description in dt-bindings and add client examples. - Update k3_ring_intr_regs reg names - Rename soc specific data to bcdma_v2_data and pktdma_v2_data to bcdma_v2_am62l_data and pktdma_v2_am62l_data. - Add a new patch [18/19] to fix a null pointer dereference issue when trying to reserve a channel id that is out of bounds in udma_reserve_##res macro. Also fix logging issues in this macro. - Add a new patch [19/19] to switch to synchronous descriptor freeing to avoid running out of memory during stress tests. - Fix checkpatch warnings. link to v3: https://lore.kernel.org/linux-arm-kernel/[email protected] Changes from v2 to v3: - Fix checkpatch errors & spellings. link to v2: https://lore.kernel.org/linux-arm-kernel/[email protected] Changes from v1 to v2: - Split refactoring of k3-udma driver into multiple commits - Fix bcdma v2 and pktdma v2 dt-binding examples - Fix compatibles in k3-udma-v2.c - move udma_is_desc_really_done to k3-udma-common.c as the difference between k3-udma and k3-udma-v2 implementation is minor. - remove udma_ prefix to function pointers in udma_dev - reorder the commits to first refactor the existing code completely and then introduce k3-udma-v2 related commits. - remove redundant includes in k3-udma-common.c - remove ti_sci_ dependency for k3_ringacc in Kconfig - refactor setup_resources functions to remove ti_sci_ code from common logic. link to v1: https://lore.kernel.org/linux-arm-kernel/[email protected] Sai Sree Kartheek Adivi (18): dmaengine: ti: k3-udma: move macros to header file dmaengine: ti: k3-udma: move structs and enums to header file dmaengine: ti: k3-udma: move static inline helper functions to header file dmaengine: ti: k3-udma: move descriptor management to k3-udma-common.c dmaengine: ti: k3-udma: move ring management functions to k3-udma-common.c dmaengine: ti: k3-udma: Add variant-specific function pointers to udma_dev dmaengine: ti: k3-udma: move udma utility functions to k3-udma-common.c dmaengine: ti: k3-udma: move resource management functions to k3-udma-common.c dmaengine: ti: k3-udma: refactor resource setup functions dmaengine: ti: k3-udma: move inclusion of k3-udma-private.c to k3-udma-common.c drivers: soc: ti: k3-ringacc: handle absence of tisci dt-bindings: dma: ti: Add K3 BCDMA V2 dt-bindings: dma: ti: Add K3 PKTDMA V2 dmaengine: ti: k3-psil-am62l: Add AM62Lx PSIL and PDMA data dmaengine: ti: k3-udma-v2: New driver for K3 BCDMA_V2 dmaengine: ti: k3-udma-v2: Add support for PKTDMA V2 dmaengine: ti: k3-udma-v2: Update glue layer to support PKTDMA V2 dmaengine: ti: k3-udma: Validate resource ID and fix logging in reservation Vignesh Raghavendra (1): dmaengine: ti: k3-udma: Fix sporadic crash on AM62x .../bindings/dma/ti/ti,am62l-dmss-bcdma.yaml | 211 ++ .../bindings/dma/ti/ti,am62l-dmss-pktdma.yaml | 189 + drivers/dma/ti/Kconfig | 21 +- drivers/dma/ti/Makefile | 5 +- drivers/dma/ti/k3-psil-am62l.c | 169 + drivers/dma/ti/k3-psil-priv.h | 5 + drivers/dma/ti/k3-psil.c | 78 +- drivers/dma/ti/k3-udma-common.c | 2605 ++++++++++++++ drivers/dma/ti/k3-udma-glue.c | 205 +- drivers/dma/ti/k3-udma-private.c | 37 +- drivers/dma/ti/k3-udma-v2.c | 1515 ++++++++ drivers/dma/ti/k3-udma.c | 3126 +---------------- drivers/dma/ti/k3-udma.h | 602 ++++ drivers/soc/ti/k3-ringacc.c | 191 +- include/linux/dma/k3-psil.h | 3 + include/linux/soc/ti/k3-ringacc.h | 20 + 16 files changed, 5916 insertions(+), 3066 deletions(-) create mode 100644 Documentation/devicetree/bindings/dma/ti/ti,am62l-dmss-bcdma.yaml create mode 100644 Documentation/devicetree/bindings/dma/ti/ti,am62l-dmss-pktdma.yaml create mode 100644 drivers/dma/ti/k3-psil-am62l.c create mode 100644 drivers/dma/ti/k3-udma-common.c create mode 100644 drivers/dma/ti/k3-udma-v2.c -- 2.54.0