Re: [PATCH 51/61] security: update audit format strings for u64 i_ino
Paul Moore <[email protected]>
| Newsgroups | org.kernel.vger.ecryptfs,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.infradead.lists.linux-mtd,org.kernel.vger.autofs,org.kernel.vger.ceph-devel,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <CAHC9VhTPutzjNfYoRJigC2AQS4wz1A3vTEYn2koeR0kKetYk0w@mail.gmail.com> |
On Thu, Feb 26, 2026 at 11:06 AM Jeff Layton <[email protected]> wrote: > > Update %lu/%ld to %llu/%lld in security audit logging functions that > print inode->i_ino, since i_ino is now u64. > > Files updated: apparmor/apparmorfs.c, integrity/integrity_audit.c, > ipe/audit.c, lsm_audit.c. > > Signed-off-by: Jeff Layton <[email protected]> > --- > security/apparmor/apparmorfs.c | 4 ++-- > security/integrity/integrity_audit.c | 2 +- > security/ipe/audit.c | 2 +- > security/lsm_audit.c | 10 +++++----- > security/selinux/hooks.c | 4 ++-- > security/smack/smack_lsm.c | 12 ++++++------ > 6 files changed, 17 insertions(+), 17 deletions(-) ... > diff --git a/security/lsm_audit.c b/security/lsm_audit.c > index 7d623b00495c14b079e10e963c21a9f949c11f07..737f5a263a8f79416133315edf363ece3d79c722 100644 > --- a/security/lsm_audit.c > +++ b/security/lsm_audit.c Everything in security/lsm_audit.c looks okay. > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index d8224ea113d1ac273aac1fb52324f00b3301ae75..150ea86ebc1f7c7f8391af4109a3da82b12d00d2 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -1400,7 +1400,7 @@ static int inode_doinit_use_xattr(struct inode *inode, struct dentry *dentry, > if (rc < 0) { > kfree(context); > if (rc != -ENODATA) { > - pr_warn("SELinux: %s: getxattr returned %d for dev=%s ino=%ld\n", > + pr_warn("SELinux: %s: getxattr returned %d for dev=%s ino=%lld\n", > __func__, -rc, inode->i_sb->s_id, inode->i_ino); > return rc; > } Additionally, later in this function there are pr_notice_ratelimited() and pr_warn() calls that print inode numbers and need to be updated. -- paul-moore.com