Re: [PATCH 03/61] trace: update VFS-layer trace events for u64 i_ino
Damien Le Moal <[email protected]>
| Newsgroups | org.kernel.vger.ecryptfs,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mtd,org.kernel.vger.autofs,org.kernel.vger.ceph-devel,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Organization | Western Digital Research |
| Message-ID | <[email protected]> |
On 2/27/26 00:55, Jeff Layton wrote: > Update trace event definitions in VFS-layer trace headers to use u64 > instead of ino_t/unsigned long for inode number fields, and change > format strings from %lu/%lx to %llu/%llx to match. > > This is needed because i_ino is now u64. Changing trace event field > types changes the binary trace format, but the self-describing format > metadata handles this transparently for modern trace-cmd and perf. > > Files updated: > - cachefiles.h, filelock.h, filemap.h, fs_dax.h, fsverity.h, > hugetlbfs.h, netfs.h, readahead.h, timestamp.h, writeback.h > > Signed-off-by: Jeff Layton <[email protected]> [...] > @@ -726,7 +726,7 @@ TRACE_EVENT(balance_dirty_pages, > __entry->pause, /* ms */ > __entry->period, /* ms */ > __entry->think, /* ms */ > - (unsigned long)__entry->cgroup_ino > + (unsigned long long)__entry->cgroup_ino Do we really need this cast here ? (same comment for the following events). Other than this, this looks OK to me. Reviewed-by: Damien Le Moal <[email protected]> -- Damien Le Moal Western Digital Research