Re: [PATCH 1/7] ecryptfs: streamline truncate_upper

On Mon, Apr 06, 2026 at 12:52:05AM -0500, Tyler Hicks wrote:
> On 2026-03-31 17:37:22, Christoph Hellwig wrote:
> > Use a few strategic gotos to keep reduce indentation and keep the
> > main reduce size flow outside of branches.  Switch all touched comments
> 
> I think that first sentence was supposed to say, "Use a few strategic
> gotos to reduce indentation and keep the main flow outside of branches."
> Could you confirm?

Yes.

> > +		/*
> > +		 * Write a single 0 at the last position of the file; this
> > +		 * triggers code that will fill in 0's throughout the
> > +		 * intermediate portion of the previous end of the file and the
> > +		 * new and of the file.
> 
> Since we're touching this comment, we might as well fix the typo:
> 
>  s/new and of the file/new end of the file/
> 
> I can do both of these small changes when merging, if we don't have a
> better reason to respin this series.

I'll fix it up when I resend, and it looks like we're need another version
anyway.