Re: cleanup truncate handling in ecryptfs v2
Tyler Hicks <[email protected]> Tue, 7 Apr 2026 20:10:29 -0500
| Newsgroups | org.kernel.vger.ecryptfs,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <adWrBVPMUj0otxi_@yaupon> |
On 2026-04-07 07:50:27, Christoph Hellwig wrote: > On Tue, Apr 07, 2026 at 04:02:36PM +0200, Christoph Hellwig wrote: > > Hi Tyler, > > > > this series cleans up the truncate handling in ecryptfs. I did > > it as preparation for some changes into size changing truncate > > VFS interfaces I'm looking into in the moment. The changes have > > passed the regression test suite in the userspace ecryptfs > > repository and against the ecryptfs next branch. > > So right after I posted this I came up with an idea how to better > pass arguments to the low-level truncate helper as the size + lower_ia > kept irking me. The branch here: > > https://git.infradead.org/?p=users/hch/misc.git;a=shortlog;h=refs/heads/ecryptfs-truncate > > simply only passed the upper ia, which feels a lot cleaner. It passes > the ecryptfs test suite, but otherwise is hot off the press. If you > like the new version I'll send it out tomorrow. > Yep, that's the right thing to do. Thanks for give it more thought. I only had time to do a diff between v1 and this branch. The code changes look good. One tiny typo in a code comment: s/file systen/file system/ Tyler