Re: [PATCH 6/8] t/zbd: set badblocks related parameters in run-tests-against-nullb

On Apr 24, 2025 / 11:02, Vincent Fu wrote:
> On 4/21/25 8:38 AM, Shin'ichiro Kawasaki wrote:
> > As a preparation to add test cases which check that the
> > continue_on_error option and the recover_zbd_write_error option work
> > when bad blocks cause IO errors, set additional null_blk parameters
> > badblocks_once and badblocks_partial_io. These parameters were added to
> > Linux kernel recently and allows more realistic scenario of write
> > failures on zoned block devices. The former parameter makes the
> > specified badblocks recover after the first write, and the latter
> > parameter leaves partially written data on the device.
> > 
> > Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
> > ---
> >   t/zbd/run-tests-against-nullb | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/t/zbd/run-tests-against-nullb b/t/zbd/run-tests-against-nullb
> > index 97d29966..f1cba355 100755
> > --- a/t/zbd/run-tests-against-nullb
> > +++ b/t/zbd/run-tests-against-nullb
> > @@ -91,6 +91,9 @@ configure_nullb()
> >   		fi
> >   	fi
> > +	[[ -w badblocks_once ]] && echo 1 > badblocks_once
> > +	[[ -w badblocks_partial_io ]] && echo 1 > badblocks_partial_io
> > +
> >   	echo 1 > power || return $?
> >   	return 0
> >   }
> 
> It would be helpful to have the first kernel version supporting these
> parameters noted in the commit message. This would make things easier for
> anyone setting up a test environment.

Sure, will add the kernel version "6.15-rc1" in the commit message.