Re: [PATCH] configure: Fix libnfs cflags and libs
Vincent Fu <[email protected]>
| Newsgroups | org.kernel.vger.fio |
|---|---|
| Message-ID | <[email protected]> |
On 5/9/25 5:50 AM, Damien Le Moal wrote: > libnfs version 16 requires the gnutls library. Without specifying at > least -lgnutls, builds fail: > > LINK fio > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/15/../../../../lib64/libnfs.so: undefined reference to `gnutls_certificate_set_x509_trust_dir' > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/15/../../../../lib64/libnfs.so: undefined reference to `gnutls_transport_set_int2' > ... > > Modify the configure script to add cflags and library options for gnutls > to correctly build libnfs engine. > > Signed-off-by: Damien Le Moal <[email protected]> > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 715f0602..986eb0a6 100755 > --- a/configure > +++ b/configure > @@ -2361,8 +2361,8 @@ print_config "DAOS File System (dfs) Engine" "$dfs" > if test "$libnfs" != "no" ; then > if $(pkg-config libnfs > /dev/null 2>&1); then > libnfs="yes" > - libnfs_cflags=$(pkg-config --cflags libnfs) > - libnfs_libs=$(pkg-config --libs libnfs) > + libnfs_cflags=$(pkg-config --cflags libnfs gnutls) > + libnfs_libs=$(pkg-config --libs libnfs gnutls) > else > if test "$libnfs" = "yes" ; then > feature_not_found "libnfs" "libnfs" The test builds fail because we do not install gnutls development libraries on the test platforms. Adding the diff below to the patch should resolve the failures. Vincent diff --git a/ci/actions-install.sh b/ci/actions-install.sh index ad352317..30b815f3 100755 --- a/ci/actions-install.sh +++ b/ci/actions-install.sh @@ -32,6 +32,7 @@ DPKGCFG libcunit1-dev libcurl4-openssl-dev libfl-dev + libgnutls28-dev libnuma-dev libnfs-dev valgrind @@ -106,6 +107,7 @@ install_fedora() { bison-devel git flex-devel + gnutls-devel gperftools isa-l-devel kernel-devel