Re: [PATCH] fio_sem, diskutil: introduce fio_shared_sem and use it for diskutil lock

On May 12, 2025 / 07:16, Jens Axboe wrote:
> On 5/11/25 7:30 PM, Shin'ichiro Kawasaki wrote:
...
> > +struct fio_sem *fio_shared_sem_init(int value)
> > +{
> > +	struct fio_sem *sem = NULL;
> 
> Pointless initialization, you overwrite it right after.
> 
> > +	sem = smalloc(sizeof(struct fio_sem));
> > +	if (!sem) {
> > +		perror("fio: smalloc for semaphore failed");
> > +		return NULL;
> > +	}
> 
> smalloc() doesn't set errno, and logs an error separately.

Thanks. I will reflect the comments and send out v2 soon.