Re: [PATCH] Add Zhaoxin support to enable tsc_reliable and arch_random features

Sitsofe Wheeler <[email protected]> Thu, 22 May 2025 09:07:05 +0100
Newsgroups org.kernel.vger.fio
Message-ID <CALjAwxh2iGf2FQYOTieMdT+3ZURkwhOwDOBrfYGO3tYLfXAwUQ@mail.gmail.com>
Hi,

On Thu, 22 May 2025 at 06:55, Runa Guo-oc <[email protected]> wrote:
>
> Signed-off-by: Runa Guo-oc <[email protected]>
> ---
>  arch/arch-x86-common.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
<snip>

On Thu, 22 May 2025 at 07:51, <[email protected]> wrote:
>
>
> The result of fio's continuous integration tests was: failure
>
> For more details see https://github.com/fiotestbot/fio/actions/runs/15179641974

The bot has a point:

crc/../arch/arch-x86-common.h: In function ‘arch_init’:
135crc/../arch/arch-x86-common.h:71:43: error: expected expression
before ‘||’ token
136 71 | if (!strcmp(str, "GenuineIntel")) || (!strcmp(str, " Shanghai ") ||
137 | ^~
138crc/../arch/arch-x86-common.h:71:43: error: expected expression
before ‘||’ token
139 71 | if (!strcmp(str, "GenuineIntel")) || (!strcmp(str, " Shanghai ") ||
140 | ^~
141

Have you compiled and run this change to check it does what you expect?

-- 
Sitsofe