Re: [PATCH 0/2] verify: fix issues of verify state handling improvement
Riley Thomasson <[email protected]> Mon, 11 Aug 2025 11:55:44 -0700
| Newsgroups | org.kernel.vger.fio |
|---|---|
| Message-ID | <CAM4SYzyzYAP+DiL9sCP6Jwog_ZRzUR6YToSNfad+9vHNg1o7nw@mail.gmail.com> |
Thank you for catching these! The sync error path is a bit subtle but the version bump is a facepalm. On Sat, Aug 9, 2025 at 7:28 AM Jens Axboe <[email protected]> wrote: > > > On Sat, 09 Aug 2025 10:15:53 +0900, Shin'ichiro Kawasaki wrote: > > Recently, verify state handling was improved through GitHub PR 1951 [1]. > > My thank goes to Riley Thomasson. The work provided the fundamental fix > > for the out-of-order write completion issue :) > > > > However, I observed the work introduced two issues. The first issue is > > unbalanced calls of log_inflight() and invalidate_inflight() during > > write failures, which leads to fio run stops by aborts. The second issue > > is verify state file data structure change without file version > > increment. This patch series addresses these two issues by two patches > > respectively. > > > > [...] > > Applied, thanks! > > [1/2] verify: fix write tracking in error cases > commit: 1e6ca399f8b5062fcb4be3b043b7355a0617afb6 > [2/2] verify: bump up verify state file version > commit: a52833b3295f0fae160eb3d4937a371756d6d929 > > Best regards, > -- > Jens Axboe > > >