Re: [PATCH 1/2] stat: report zone reset count only when zonemode is set to zbd
Shinichiro Kawasaki <[email protected]> Thu, 9 Oct 2025 01:49:51 +0000
| Newsgroups | org.kernel.vger.fio |
|---|---|
| Message-ID | <xtbr4pdxvo66ji5z6eugr4ypq2xfa2kjvhprxh5ikc5z7usnd3@fyja5vm2sc4s> |
On Oct 08, 2025 / 08:18, Jens Axboe wrote: > On 10/8/25 3:48 AM, Shin'ichiro Kawasaki wrote: > > Currently, fio reports the zone reset count regardless of whether the > > zbd zonemode is specified. Reporting the zone reset count lacking the > > zbd zonemode is irrelevant and unnecessary. > > > > Suppress the zone reset count report unless the zbd zonemode is > > specified. For that purpose, introduce the new flag "count_zone_resets" > > to the struct thread_stat. To maintain 32-bit alignment of the struct, > > repurpose the existing "pad3" field to allocate the flag. To group the > > related fields together, move the field "nr_zone_resets" and > > "latency_depth" within the struct. Make corresponding adjustments in the > > relevant functions fio_server_send_ts() and convert_ts(). Set the flag > > count_zone_resets only when the zbd zonemode is set, and the workload is > > write or trim. Refer to the flag in show_ddir_status() to determine if > > the zone reset count should be reported. Also refer to the flag in > > sum_thread_stats() to decide if the nr_zone_resets field should be > > summed up. > > This one needs a FIO_SERVER_VER increment as it's modifying thread_stat. Ah, I see, FIO_SERVER_VER should be incremented when data structures used in server.h changes. Will send out v2. Thanks.