[PATCH 05/12] zbd: remove io_u_quiesce() at write target zone switch
Shin'ichiro Kawasaki <[email protected]> Fri, 9 Jan 2026 11:35:56 +0900
| Newsgroups | org.kernel.vger.fio |
|---|---|
| Message-ID | <[email protected]> |
zbd_convert_to_write_zones() calls io_u_quiesce() when write target zone changes. This call was hiding the bug fixed by the previous commit. Now it is safe to remove the io_u_quiesce() call. Remove it. This avoids the performance drop at write target zone switch. Signed-off-by: Shin'ichiro Kawasaki <[email protected]> --- zbd.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/zbd.c b/zbd.c index e5f4c8f6..2682babb 100644 --- a/zbd.c +++ b/zbd.c @@ -1507,7 +1507,6 @@ static struct fio_zone_info *zbd_convert_to_write_zone(struct thread_data *td, struct fio_zone_info *z; uint32_t zone_idx, new_zone_idx; int i; - bool wait_zone_write; bool in_flight; bool should_retry = true; @@ -1589,29 +1588,10 @@ examine_zone: } choose_other_zone: - /* Check if number of write target zones reaches one of limits. */ - wait_zone_write = - zbdi->num_write_zones == f->max_zone - f->min_zone || - (zbdi->max_write_zones && - zbdi->num_write_zones == zbdi->max_write_zones) || - (td->o.job_max_open_zones && - td->num_write_zones == td->o.job_max_open_zones); - pthread_mutex_unlock(&zbdi->mutex); /* Only z->mutex is held. */ - /* - * When number of write target zones reaches to one of limits, wait for - * zone write completion to one of them before trying a new zone. - */ - if (wait_zone_write) { - dprint(FD_ZBD, - "%s(%s): quiesce to remove a zone from write target zones array\n", - __func__, f->file_name); - io_u_quiesce(td); - } - retry: /* * For random writes, retry from the zone chosen at the beginning using -- 2.49.0