Re: [PATCH v2] Introduce the end_syncfs option

Vincent Fu <[email protected]> Mon, 26 Jan 2026 20:01:51 -0500
Newsgroups org.kernel.vger.fio
Message-ID <CAOp=CX=dWPmgjKhZFK8BDKA57qyYJKCJkYBKYOLynU1n6bi=ug@mail.gmail.com>
On Mon, Jan 26, 2026 at 1:22 AM Damien Le Moal <[email protected]> wrote:
>
<snip>
>                 }
> +
> +               if (td->o.end_syncfs) {
> +                       td_set_runstate(td, TD_FSYNCING);
> +
> +                       for_each_file(td, f, i) {
> +                               if (fio_file_syncfs(td, f))
> +                                       log_err("fio: end_syncfs failed\n");
> +                               break;

This seems like it will break out of the loop after syncfs-ing the first file.
Is this intentional or should fio break only if there is an error?

Vincent