Re: [PATCH] xfs: test that zone_gc_low_space writes start gc for rw fses

Christoph Hellwig <[email protected]>
Newsgroups org.kernel.vger.fstests,org.kernel.vger.linux-xfs
Message-ID <[email protected]>
On Thu, Mar 26, 2026 at 01:41:46PM +0000, Hans Holmberg wrote:
> That would be useful I think.
> And make them not specific to scratch?
> 
> _xfs_get_mountstats <MOUNTPOINT>
> _xfs_get_rt_gc_required <MOUNTPOINT>
> _xfs_get_user_available_rt_blocks <MOUNTPOINT>

Sounds good!

> 
> > 
> >> +
> >> +# figure out if the rt section is internal or not
> >> +if [ -z "$SCRATCH_RTDEV" ]; then
> >> +	zdev=$SCRATCH_DEV
> >> +else
> >> +	zdev=$SCRATCH_RTDEV
> >> +fi
> > 
> > Same for this asa new helper?
> 
> Yes, something like:
> 
> _xfs_get_scratch_rtdev

Maybe _xfs_get_scratch_rtdev_bdev?  That might sounds a bit redundant,
but I think that's good to make the usage of this clear.  A comment
explaining it would also be useful here.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.