Re: [PATCH v2 2/2] xfs: test that zone_gc_low_space writes start gc for rw fses

On Mon, Mar 30, 2026 at 07:34:21AM +0200, Christoph Hellwig wrote:
> On Fri, Mar 27, 2026 at 01:34:29PM +0100, Hans Holmberg wrote:
> > Test that writes to the sysfs attribute zone_gc_low_space triggers
> > garbage collection for rw (but not ro) file systems.
> 
> .. and add common helpers for that.  I tend to split the helpers out
> into separate commit, but I'm not sure if Zorro cares all that much
> about it.

If a new case brings in a new helper, it doesn't matter to me if we separate
the helper into a standalone patch or just bundle it with the new case.
But if introduce a series of helpers, it makes more sense to split them out.

For this patch, I won't treat the "splitting" as a blocker. If the author
isn't keen on sending another patchset, I'm fine with the current version :)

Thanks,
Zorro

> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <[email protected]>
> 
>