Re: [PATCH v2] xfs: add a test for number of open zones on conventional devices
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.fstests,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Apr 01, 2026 at 03:59:52PM +0800, Zorro Lang wrote:
> > > > +_scratch_mkfs -b size=${bsize} -r zoned=1,rgsize=${blocks}b \
> > > > + > "$seqres.full" 2>&1
> > >
> > > I usually tack on "|| _fail 'mkfs failed'" after _scratch_mount if it's
> > > using extra options. That way, we'll know for sure if the mkfs actually
> > > failed.
> >
> > Yes, that is useful here, especially if we want to support older kernels
> > before the zoned device support or !CONFIG_XFS_RT kernels.
>
> Oh, if so, we might need _require_realtime. But that's still not enough to
> check mkfs.xfs and mount.xfs on old system (then notrun), we might need
> more _require_* helpers for this test. What do you think?
I think _notrun if mkfs or the initial mount fails might be easier and
better here.