Re: [PATCH 3/4] generic/765: Ignore mkfs warning

On Wed, Apr 01, 2026 at 07:30:18AM -0700, Darrick J. Wong wrote:
> On Wed, Apr 01, 2026 at 04:10:49PM +0530, Ojaswin Mujoo wrote:
> > From: Super User <[email protected]>
> 
> Who?

Ahh dang I'll fix this sorry about that.
> 
> > This test validates atomic writes for all possible block sizes. In ext4, for
> > smaller block sizes with configurations like:
> > 
> > export MKFS_OPTIONS="-O bigalloc,quota -b 65536 -C 131072"
> > 
> > The output can get corrupted with warnings like below because clustersize
> > more than 16xbs is experimental:
> > 
> > + 16 times the block size is considered experimental
> 
> Er... a message that doesn't fail the mkfs is printed to stderr?
> Maybe mke2fs should fix that...

Hmm yes makes sense, I'll try to make that change in e2fsprogs.
Hopefully noone is depending on such a message showing up in stderr.

> 
> > Hence pipe these to seqres.full to avoid false negatives.
> > 
> > Reported-by: Disha Goel <[email protected]>
> > Signed-off-by: Ojaswin Mujoo <[email protected]>
> > ---
> >  tests/generic/765 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/generic/765 b/tests/generic/765
> > index 4c768783..6794eb72 100755
> > --- a/tests/generic/765
> > +++ b/tests/generic/765
> > @@ -64,7 +64,7 @@ test_atomic_writes()
> >      local bsize=$1
> >  
> >      get_mkfs_opts $bsize
> > -    _scratch_mkfs $mkfs_opts >> $seqres.full
> > +    _scratch_mkfs $mkfs_opts >> $seqres.full 2>&1
> 
> I think we still want to check that the format succeeded as a
> precondition for the test round, right?
> 
> 	_scratch_mkfs $mkfs_opts &>> $seqres.full || \
> 		echo "mkfs $mkfs_opts" failed"
> 
> --D

Yes makes sense, I'll do that. 

Thanks for the review,
Ojaswin.
> 
> >      _scratch_mount
> >  
> >      test "$FSTYP" = "xfs" && _xfs_force_bdev data $SCRATCH_MNT
> > -- 
> > 2.53.0
> > 
> >