Re: [PATCH v2] xfs: add a test for number of open zones on conventional devices

On Wed, Apr 01, 2026 at 04:06:46PM +0200, Christoph Hellwig wrote:
> On Wed, Apr 01, 2026 at 03:59:52PM +0800, Zorro Lang wrote:
> > > > > +_scratch_mkfs -b size=${bsize} -r zoned=1,rgsize=${blocks}b \
> > > > > +	> "$seqres.full" 2>&1
> > > > 
> > > > I usually tack on "|| _fail 'mkfs failed'" after _scratch_mount if it's
> > > > using extra options. That way, we'll know for sure if the mkfs actually
> > > > failed.
> > > 
> > > Yes, that is useful here, especially if we want to support older kernels
> > > before the zoned device support or !CONFIG_XFS_RT kernels.
> > 
> > Oh, if so, we might need _require_realtime. But that's still not enough to
> > check mkfs.xfs and mount.xfs on old system (then notrun), we might need
> > more _require_* helpers for this test. What do you think?
> 
> 
> I think _notrun if mkfs or the initial mount fails might be easier and
> better here.

How about a _require_xfs_mkfs_zoned ?

And about `_scratch_mount -o max_open_zones=${open_zones}`, if max_open_zones
mount option isn't supported, _scratch_mount will fail directly. So how about

  _try_scratch_mount -o max_open_zones=${open_zones} || \
          _notrun "max_open_zones option is not supported"

Or we can have a helper for that, as xfs/642~644 and xfs/668 also need that.

Thanks,
Zorro

>