Re: [PATCH 4/6] generic/765: Ignore mkfs warning
"Darrick J. Wong" <[email protected]>
| Newsgroups | org.kernel.vger.fstests |
|---|---|
| Message-ID | <20260410165435.GU6212@frogsfrogsfrogs> |
On Fri, Apr 10, 2026 at 12:06:04PM +0530, Ojaswin Mujoo wrote: > This test validates atomic writes for all possible block sizes. In ext4, for > smaller block sizes with configurations like: > > export MKFS_OPTIONS="-O bigalloc,quota -b 65536 -C 131072" > > The output can get corrupted with warnings like below because clustersize > more than 16xbs is experimental: > > + 16 times the block size is considered experimental > > Hence pipe these to seqres.full to avoid false negatives. > > Reported-by: Disha Goel <[email protected]> > Signed-off-by: Ojaswin Mujoo <[email protected]> Seems fine, though I think I'd rather mke2fs get patched to fix this. I'd let the maintainer decide if he wants this, but ... I'm not sure if he's actually going to receive this message. :/ --D > --- > tests/generic/765 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/generic/765 b/tests/generic/765 > index 09be53db..b7cc70f1 100755 > --- a/tests/generic/765 > +++ b/tests/generic/765 > @@ -64,7 +64,8 @@ test_atomic_writes() > local bsize=$1 > > get_mkfs_opts $bsize > - _scratch_mkfs $mkfs_opts >> $seqres.full > + _scratch_mkfs $mkfs_opts &>> $seqres.full || \ > + echo "mkfs $mkfs_opts failed" > _scratch_mount > > test "$FSTYP" = "xfs" && _xfs_force_bdev data $SCRATCH_MNT > -- > 2.53.0 > >