Re: [PATCH 4/6] generic/765: Ignore mkfs warning
Zorro Lang <[email protected]>
| Newsgroups | org.kernel.vger.fstests |
|---|---|
| Message-ID | <advsFWodVwUXDrVS@zlang-laptop> |
On Fri, Apr 10, 2026 at 09:54:35AM -0700, Darrick J. Wong wrote: > On Fri, Apr 10, 2026 at 12:06:04PM +0530, Ojaswin Mujoo wrote: > > This test validates atomic writes for all possible block sizes. In ext4, for > > smaller block sizes with configurations like: > > > > export MKFS_OPTIONS="-O bigalloc,quota -b 65536 -C 131072" > > > > The output can get corrupted with warnings like below because clustersize > > more than 16xbs is experimental: > > > > + 16 times the block size is considered experimental > > > > Hence pipe these to seqres.full to avoid false negatives. > > > > Reported-by: Disha Goel <[email protected]> > > Signed-off-by: Ojaswin Mujoo <[email protected]> > > Seems fine, though I think I'd rather mke2fs get patched to fix this. > > I'd let the maintainer decide if he wants this, but ... I'm not sure if > he's actually going to receive this message. :/ Hi Darrick and folks, I'm back. I apologize for the silence these days. I had planned to do a release last week, but a sudden big regional layoff and immediate cutoff of all connections caught me completely off guard. Beyond losing my account, I lost everything on the company servers, all my documents (including a book I was halfway through writing), my code, and my entire environment for handling emails, patches, and system workflows. (This is a painful reminder to never leave your things on company server..) Amidst the shock and grief, I am now struggling to rebuild and reconfigure my local environment from scratch. I have redirected my [email protected] alias to my personal email -- [email protected]. *Please do not send any more emails to my old [email protected] address*. Starting tomorrow, I will begin reviewing and merging last week's patches bit by bit. I still need long time to get my environment and workflows back in order, in the meantime, I will also be focusing my energy on finding a new job. So I appreciate everyone's patience and understanding. > > --D > > > --- > > tests/generic/765 | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tests/generic/765 b/tests/generic/765 > > index 09be53db..b7cc70f1 100755 > > --- a/tests/generic/765 > > +++ b/tests/generic/765 > > @@ -64,7 +64,8 @@ test_atomic_writes() > > local bsize=$1 > > > > get_mkfs_opts $bsize > > - _scratch_mkfs $mkfs_opts >> $seqres.full > > + _scratch_mkfs $mkfs_opts &>> $seqres.full || \ > > + echo "mkfs $mkfs_opts failed" Now for this patch, I think we can have it for unfixed e2fsprogs testing, as this test case isn't related with this e2fsprogs "bug", except you hope to uncover it by this test case :) Reviewed-by: Zorro Lang <[email protected]> > > _scratch_mount > > > > test "$FSTYP" = "xfs" && _xfs_force_bdev data $SCRATCH_MNT > > -- > > 2.53.0 > > > > >