Re: [PATCH v3] fstests: test premature ENOSPC in zoned garbage collection
Johannes Thumshirn <[email protected]>
| Newsgroups | org.kernel.vger.fstests,org.kernel.vger.linux-btrfs |
|---|---|
| Message-ID | <[email protected]> |
On 4/15/26 7:56 AM, Christoph Hellwig wrote: > On Wed, Apr 15, 2026 at 07:53:52AM +0200, Johannes Thumshirn wrote: >> On 4/15/26 7:22 AM, Christoph Hellwig wrote: >>> On Tue, Apr 14, 2026 at 04:33:41PM +0200, Johannes Thumshirn wrote: >>>> This test stresses garbage collection in zoned file systems by >>>> constantly overwriting the same file. It is inspired by a reproducer for >>>> a btrfs bugifx. >>> s/bugifx/bugfix/ >> Fixed >>> I tried this on XFS, and it doesn't work as XFS uses SCRATCH_RTDEV for >>> zoned data. Manually hacking in SCRATCH_RTDEV makes it work, but that >>> will break btrfs. Maybe you can add a little: >>> >>> if [ -b "$SCRATCH_RTDEV" ]; >>> zoned_dev=$SCRATCH_RTDEV >>> else >>> zoned_dev=$SCRATCH_DEV >>> endif >>> >>> end then use $zoned_dev to make it portable? >> Sure, can I still use _scratch_mkfs_sized for XFS? > Yes. It sizes both the main and RT device. The test still doesn't run for me on XFS: [ 160.045250] XFS (vda): EXPERIMENTAL zoned RT device feature enabled. Use at your own risk! [ 160.045707] XFS (vda): Mounting V5 Filesystem 47eb9ed8-526f-4dc3-a488-5862f403ee5c [ 160.062623] XFS (vda): Ending clean mount [ 160.062734] XFS (vda): limiting open zones to 15 due to total zone count (60) [ 160.062797] XFS (vda): 60 zones of 65536 blocks (15 max open zones) FSTYP -- xfs (non-debug) PLATFORM -- Linux/x86_64 virtme-ng 7.0.0-rc5+ #407 SMP PREEMPT_DYNAMIC Mon Mar 30 14:36:40 CEST 2026 MKFS_OPTIONS -- -f /dev/vdb MOUNT_OPTIONS -- /dev/vdb /tmp/scratch [ 160.375268] XFS (vdb): EXPERIMENTAL zoned RT device feature enabled. Use at your own risk! [ 160.375819] XFS (vdb): Mounting V5 Filesystem 24c36996-2bdd-43cc-a1d0-6fb05f87cf51 [ 160.390418] XFS (vdb): Ending clean mount [ 160.390532] XFS (vdb): limiting open zones to 15 due to total zone count (60) [ 160.390597] XFS (vdb): 60 zones of 65536 blocks (15 max open zones) [ 160.435057] XFS (vdb): Unmounting Filesystem 24c36996-2bdd-43cc-a1d0-6fb05f87cf51 [ 161.600694] XFS (vda): Unmounting Filesystem 47eb9ed8-526f-4dc3-a488-5862f403ee5c [ 161.877731] XFS (vda): EXPERIMENTAL zoned RT device feature enabled. Use at your own risk! [ 161.878359] XFS (vda): Mounting V5 Filesystem 47eb9ed8-526f-4dc3-a488-5862f403ee5c [ 161.896765] XFS (vda): Ending clean mount [ 161.896909] XFS (vda): limiting open zones to 15 due to total zone count (60) [ 161.897017] XFS (vda): 60 zones of 65536 blocks (15 max open zones) generic/999 [ 161.929562] run fstests generic/999 at 2026-04-15 08:09:50 [not run] _scratch_mkfs_sized failed with (17179869184) Ran: generic/999 Not run: generic/999 Passed all 1 tests [ 162.477746] XFS (vda): Unmounting Filesystem 47eb9ed8-526f-4dc3-a488-5862f403ee5c