Re: [PATCH v1] f2fs/{022,023}: clear MOUNT_OPTIONS alongside MKFS_OPTIONS
Zorro Lang <[email protected]>
| Newsgroups | org.kernel.vger.fstests,net.sourceforge.lists.linux-f2fs-devel |
|---|---|
| Message-ID | <afVc-ZxMAKHCpQSR@zlang-mailbox> |
On Tue, Apr 28, 2026 at 02:24:40AM +0000, Joanne Chang wrote: > Currently, f2fs/022 and f2fs/023 only clears MKFS_OPTIONS. This causes > the tests to fail when leftover MOUNT_OPTIONS depend on unapplied > MKFS_OPTIONS. So MOUNT_OPTIONS should also be cleared to ensure reliable > mounting. > > Signed-off-by: Joanne Chang <[email protected]> > --- Hmm, Makes sense to me. Reviewed-by: Zorro Lang <[email protected]> > tests/f2fs/022 | 1 + > tests/f2fs/023 | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tests/f2fs/022 b/tests/f2fs/022 > index 728ef4e8..854ec327 100755 > --- a/tests/f2fs/022 > +++ b/tests/f2fs/022 > @@ -23,6 +23,7 @@ _require_inject_f2fs_command node i_nid > > # remove all mkfs options to avoid layout change of on-disk inode > export MKFS_OPTIONS="" > +export MOUNT_OPTIONS="" > > foo_path=$SCRATCH_MNT/foo > bar_path=$SCRATCH_MNT/bar > diff --git a/tests/f2fs/023 b/tests/f2fs/023 > index 33108421..f3e8785f 100755 > --- a/tests/f2fs/023 > +++ b/tests/f2fs/023 > @@ -25,6 +25,7 @@ testfile=$SCRATCH_MNT/testfile > > # remove all mkfs options to avoid layout change of on-disk inode > export MKFS_OPTIONS="" > +export MOUNT_OPTIONS="" > > _scratch_mkfs "-O extra_attr,flexible_inline_xattr" >> $seqres.full || _fail "mkfs failed" > _scratch_mount "-o inline_xattr_size=512" >>$seqres.full 2>&1 > -- > 2.54.0.rc2.544.gc7ae2d5bb8-goog >