Re: [PATCH 2/2] btrfs: test qgroup deletion races with squota writes

Boris,


The 7.1.0-rc3-gf5d9f327e4b2 kernel includes the for-next tree
plus my latest f_fsid kernel patches.


I double-checked and the required btrfs squota patches were
indeed present:

$ git log --oneline fs/btrfs | grep "check for subvolume before"
404bf5a24f2e btrfs: check for subvolume before deleting squota qgroup
$ git log --oneline fs/btrfs | grep "forbid creating subvol qgroups"
0c309d66dacd btrfs: forbid creating subvol qgroups

Possibly the issue was likely my messed-up VM image from
SELinux + fanotifywait troubleshooting last evening.

After a fresh restart, btrfs/348 passes:

$ ./check -s gen btrfs/348
...
Ran: btrfs/348
Passed all 1 tests

Sorry for the noise!.

Looks good.


Reviewed-by: Anand Jain <[email protected]>

A small nit (which can be fixed during merge).

>>> diff --git a/tests/btrfs/348 b/tests/btrfs/348
>>> new file mode 100755
>>> index 00000000..ab816301
>>> --- /dev/null
>>> +++ b/tests/btrfs/348
>>> @@ -0,0 +1,136 @@
>>> +#! /bin/bash
>>> +# SPDX-License-Identifier: GPL-2.0
>>> +# Copyright (c) 2024 Meta Platforms, Inc.  All Rights Reserved.
Do you need this to be   `s/2024/2026/`  ?

Thanks.