[PATCH 1/2] tools/mvtest: align the output format between new and mvtest
Zorro Lang <[email protected]>
| Newsgroups | org.kernel.vger.fstests |
|---|---|
| Message-ID | <[email protected]> |
Maintainers frequently rely on mvtest to manage new cases. Therefore,
./new and ./mvtest should have a consistent output format during case
creation and transfer. Otherwise, it can lead to maintenance issues,
such as regex failures failing to update the case numbers properly.
About 10 years ago, 03c633bff6e4 ("build: Allow alphanumeric test
name suffixes") made below change in new script:
-# FS QA Test No. $id
+# FS QA Test $id
However, the mvtest script still uses the "# FS QA Test No. ${did}".
Although we've fixed the regex mismatch issue, unify the output
format across both scripts will prevent future maintenance issues.
Signed-off-by: Zorro Lang <[email protected]>
---
tools/mvtest | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/mvtest b/tools/mvtest
index 09a9982b..0541d237 100755
--- a/tools/mvtest
+++ b/tools/mvtest
@@ -36,7 +36,7 @@ git mv "tests/${src}" "tests/${dest}"
git mv "tests/${src}.out" "tests/${dest}.out"
# make sure testcase is executable
chmod a+x "tests/${dest}"
-sed -e "s/^# FS[[:space:]]*QA.*Test.*[0-9]\+$/# FS QA Test No. ${did}/g" -i "tests/${dest}"
+sed -e "s/^# FS[[:space:]]*QA.*Test.*[0-9]\+$/# FS QA Test ${did}/g" -i "tests/${dest}"
sed -e "s/^QA output created by ${sid}$/QA output created by ${did}/g" -i "tests/${dest}.out"
sed -e "s/test-${sid}/test-${did}/g" -i "tests/${dest}.out"
--
2.54.0