Re: [PATCH] fstests: generic/362: remove the old file to reflect new mount options
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.fstests,org.kernel.vger.linux-btrfs |
|---|---|
| Message-ID | <[email protected]> |
On Tue, May 26, 2026 at 04:30:55PM +0930, Qu Wenruo wrote: > Silence is golden > ... > (Run 'diff -u /home/adam/xfstests/tests/generic/362.out /home/adam/xfstests/results//generic/362.out.bad' to see the entire diff) > > But if one has formated TEST_DEV, run test with default mount option, > then change the mount option to "nodatasum", the test will not fail > anymore: > [FIX] > Always delete the target file "$TEST_DIR/dio-append-buf-fault" before > running dio-append-buf-fault command. > > So that the new target file is always newly created and will follow > btrfs' new mount option and expose the failure for nodatasum. I'd rather add a copy of the test that runs on the scratch device that can control the environment. Or maybe just change the test to use the scratch device?