Re: [PATCH 2/2] xfs/21[67]: fix mkfs log concurrency detection

On Thu, May 28, 2026 at 09:21:31PM -0700, Darrick J. Wong wrote:
> On Sun, May 24, 2026 at 10:46:08PM -0700, Christoph Hellwig wrote:
> > On Wed, May 20, 2026 at 12:01:12PM -0700, Darrick J. Wong wrote:
> > > +_mkfs_xfs_supported()
> > 
> > Can you add a top of function comment explaininging this helper?
> 
> Done:
> 
> # Figure out if the supplied mkfs.xfs options are supported.  A device
> # or file path must be specified as one of the options, though it will
> # not be written.

Sounds good.

> Digression: I wonder if _scratch_mkfs_xfs_supported should have a
> "-f" in its $XFS_MKFS_PROG invocations?

Probably, otherwise if you run this when something else was on the
device it randomly fails.