Re: [PATCH RFC] fstests: use MOUNT_OPTIONS to populate TEST_FS_MOUNT_OPTS if possible
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.fstests,org.kernel.vger.linux-btrfs |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jun 02, 2026 at 09:44:22AM +0930, Qu Wenruo wrote:
> If the test config only specifies "MOUNT_OPTIONS", but not
> "TEST_FS_MOUNT_OPTS", the mount for TEST_DIR can have inconsistent flag
> after _test_cycle_mount().
AFAIK TEST_FS_MOUNT_OPTS gets overriden and isn't even a public option.
It gets filled by fstype-sepcific options in _common_mount_opts.
This started to really confuse me lately when I was trying to test with
mount options on the test fs.
I've looked at bit into the area but haven't come to a conclusion yet.
The most recent change in this area is 1dd7395623cb ("common/config:
Make test and scratch devices use the same mount options"), which didn't
really make them common, adding to my confusion.
So I really think we need to fix things here, but right now I'm not sure
how much of the current situation is intentional, and what our final
goal is :(