Re: [PATCH] generic/740: set env for mkfs.exfat and mkfs.ntfs

On Wed, Jun 17, 2026 at 01:57:31AM +0900, David Timber wrote:
> +case "$FSTYP" in
> +	exfat)

Please don't indent the matches in case statements (yes, we probably
have a few legacy cases that do it, but copy the right ones :))

> +		# Some fsprogs were slow to implement foreign fs detection.
> +		# For backward compatibility, mkfs.exfat refuses to format only
> +		# when run from a tty. This env var should override the
> +		# behaviour if supported.

I don't get the 'Some fsprogs' part here.  Maybe just drop that line?

>  	ntfs)
> -		# "quick" format that doesn't zero the entire device
> -		postargs="--quick"
> +		# "quick" format that doesn't zero the entire device. Use -F so
> +		# that NTFS-3G mkfs formats the volume even if the scratch
> +		# blockdev is not a partition.
> +		postargs="-QF"

Why does this switch from the long to the short form quick argument?

>  		echo "=== Attempting $FSTYP overwrite of $fs..." >>$seqres.full
> -		${MKFS_PROG} -t $FSTYP $SCRATCH_DEV >>$seqres.full 2>&1
> +		eval $mkfs_preop ${MKFS_PROG} -t $FSTYP $mkfs_preargs $SCRATCH_DEV $mkfs_postargs >>$seqres.full 2>&1

Maybe add a line break to keep the line at a reasonable length.

Also in doubt split the exfat and ntfs changes as they seem entirely
unrelated.