[PATCH 0/2] vfstest: fix tcore_acls() cleanup bug and missing _require_acls

German Maglione <[email protected]> Thu, 18 Jun 2026 12:11:52 +0200
Newsgroups org.kernel.vger.fstests,org.kernel.vger.linux-fsdevel
Message-ID <[email protected]>
Hi,

Running xfstests over virtiofs I hit failures in generic/633, 644,
645, 656 and 696. Two issues in tcore_acls():

1) sys_umount2() only runs on the success path. When setfacl fails,
   the mount is left behind and every test after that fails with
   EEXIST.

2) generic/633 doesn't declare _require_acls, so it fails instead
   of being skipped on filesystems without ACL support.

Signed-off-by: German Maglione <[email protected]>
---
German Maglione (2):
      vfstest: move sys_umount2() to cleanup path in tcore_acls()
      generic/633: add _require_acls for tcore_acls() ACL dependency

 src/vfs/idmapped-mounts.c | 5 ++---
 tests/generic/633         | 1 +
 2 files changed, 3 insertions(+), 3 deletions(-)
---
base-commit: cac9fe2b8dc3e6dbc0c2383b9e3b4d3c1b9e7dd0
change-id: 20260618-xfstests-tcore-acls-fixes-6d15a696f652

Best regards,
-- 
German Maglione <[email protected]>