Re: [PATCH 2/2] generic/633: add _require_acls for tcore_acls() ACL dependency

On Thu, Jun 18, 2026 at 12:11:54PM +0200, German Maglione wrote:
> generic/633 runs --test-core which includes tcore_acls(). Without
> _require_acls, the test fails instead of being skipped on filesystems
> that lack ACL support.
> 
> Signed-off-by: German Maglione <[email protected]>
> ---
>  tests/generic/633 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/633 b/tests/generic/633
> index d75d4dc860d3b78e5fe11b538e3aba4e9ab477e1..90d24f099bc732d5db209f8d014ddaeb042985b2 100755
> --- a/tests/generic/633
> +++ b/tests/generic/633
> @@ -14,6 +14,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink
>  
>  _require_test
>  _require_chown
> +_require_acls

_require_acls is in common/attr which isn't imported automatically.
I'll help to do:

  . ./common/attr

when I merge this patch.

Reviewed-by: Zorro Lang <[email protected]>

Thanks,
Zorro

>  
>  echo "Silence is golden"
>  
> 
> -- 
> 2.49.0
>