Re: [PATCH 2/2] xfs/65[56]: don't unset SCRATCH_RTDEV here
"Darrick J. Wong" <[email protected]> Thu, 2 Jul 2026 08:24:07 -0700
| Newsgroups | org.kernel.vger.fstests,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <20260702152407.GE9381@frogsfrogsfrogs> |
On Thu, Jul 02, 2026 at 12:36:33PM +0200, Christoph Hellwig wrote: > On Wed, Jul 01, 2026 at 08:57:59PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <[email protected]> > > > > Both of these tests claim that they have to unset SCRATCH_RTDEV to avoid > > formatting failures due to the rt bitmap consuming all the space in the > > "small" data device. However, the format doesn't constrain the size of > > the data device, so the justification doesn't apply. Remove the whole > > thing. > > Looks good, but as-is clashes with my > "formalize and fix disabling the RT subvolume" patch. It might make > sense to take these two patches first, and then modified version > of > > "formalize and fix disabling the RT subvolume" > > and > > "common: skip data write EIO survival tests on fatal configs" > > on top of that. Whatever order's most convenient for you is 100% ok with me. That said, yes, let's remove the braindamage from xfs/65[56] first. --D