Re: [PATCH v2] generic/795: add unaligned boundary test cases for WRITE_ZEROES

Christoph Hellwig <[email protected]> Mon, 13 Jul 2026 12:04:14 +0200
Newsgroups org.kernel.vger.fstests,org.kernel.vger.linux-ext4,org.kernel.vger.linux-xfs
Message-ID <[email protected]>
On Fri, Jul 10, 2026 at 04:23:27PM +0800, Zhang Yi wrote:
> Thank you for the test! The changes look good to me, and it works well
> with my ext4 fixes as well.
> 
> Reviewed-by: Zhang Yi <[email protected]>
> 
> Unfortunately, I've found a bug in filefrag that causes delalloc extents
> to be reported with a length of 0. This means this test case can miss
> delalloc extents. The issue is in misc/filefrag.c's print_extent_info(),
> where ext_len is incorrectly set to 0 for the FIEMAP_EXTENT_UNKNOWN or
> EXT4_FIEMAP_EXTENT_HOLE cases. Could you please send a patch to fix this
> as well?

We can't really rely on having a bleeding edge filefrag for xfstests
(well, at least without a feature check for it, but even that
would not a good usability story).  I guess at least for now
we might have to add  a little tool that just calls FIEMAP for
us to xfstests?