Re: [PATCH] xfs: remove the v2log group

On Thu, Jun 18, 2026 at 03:45:28PM +0200, Christoph Hellwig wrote:
> v2log have been the default for more than a decade.  Merge all xfs log
> tests into the log group instead of splitting them up (with a lot of
> overlap).
> 
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---

Highly welcome the reorganization of the groups. As the number of test
cases in xfstests grows, a clearer and more effective group classification
will definitely be helpful.

Reviewed-by: Zorro Lang <[email protected]>

>  doc/group-names.txt | 1 -
>  tests/generic/054   | 2 +-
>  tests/generic/055   | 2 +-
>  tests/xfs/095       | 2 +-
>  tests/xfs/119       | 2 +-
>  tests/xfs/135       | 2 +-
>  tests/xfs/137       | 2 +-
>  7 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/doc/group-names.txt b/doc/group-names.txt
> index 158f84d36d31..424e2c4a1ca6 100644
> --- a/doc/group-names.txt
> +++ b/doc/group-names.txt
> @@ -142,7 +142,6 @@ union			tests from the unionmount test suite
>  unlink			O_TMPFILE unlinked files
>  unreliable_in_parallel	randomly fail when run in parallel with other tests
>  unshare			fallocate FALLOC_FL_UNSHARE_RANGE
> -v2log			XFS v2 log format tests
>  verity			fsverity
>  volume			btrfs volume management
>  whiteout		overlayfs whiteout functionality
> diff --git a/tests/generic/054 b/tests/generic/054
> index 0649b25930c6..f6eb8975b32e 100755
> --- a/tests/generic/054
> +++ b/tests/generic/054
> @@ -9,7 +9,7 @@
>  # In another qa test we can do more e.g. use fsstress.
>  #
>  . ./common/preamble
> -_begin_fstest shutdown log v2log auto
> +_begin_fstest shutdown log auto
>  
>  # Import common functions.
>  . ./common/filter
> diff --git a/tests/generic/055 b/tests/generic/055
> index e57f95faf897..f87fd7fb1850 100755
> --- a/tests/generic/055
> +++ b/tests/generic/055
> @@ -9,7 +9,7 @@
>  # * also can interrupt metadata with godown
>  #
>  . ./common/preamble
> -_begin_fstest shutdown log v2log auto quota stress
> +_begin_fstest shutdown log auto quota stress
>  
>  # Import common functions.
>  . ./common/filter
> diff --git a/tests/xfs/095 b/tests/xfs/095
> index da0d2ae4bb57..ab2ccfc7361c 100755
> --- a/tests/xfs/095
> +++ b/tests/xfs/095
> @@ -7,7 +7,7 @@
>  # Test upgrading the XFS log to v2
>  #
>  . ./common/preamble
> -_begin_fstest log v2log auto
> +_begin_fstest log auto
>  
>  # Import common functions.
>  . ./common/filter
> diff --git a/tests/xfs/119 b/tests/xfs/119
> index 7c1cd6a50ce5..e44d5a996a96 100755
> --- a/tests/xfs/119
> +++ b/tests/xfs/119
> @@ -9,7 +9,7 @@
>  # This can hang when things aren't working
>  #
>  . ./common/preamble
> -_begin_fstest log v2log auto freeze
> +_begin_fstest log auto freeze
>  
>  # Override the default cleanup function.
>  _cleanup()
> diff --git a/tests/xfs/135 b/tests/xfs/135
> index ec0b54ab45c3..e8c490a0c13f 100755
> --- a/tests/xfs/135
> +++ b/tests/xfs/135
> @@ -9,7 +9,7 @@
>  # and verified with xfs_logprint.
>  #
>  . ./common/preamble
> -_begin_fstest auto logprint quick v2log
> +_begin_fstest auto logprint quick log
>  
>  # Import common functions.
>  . ./common/log
> diff --git a/tests/xfs/137 b/tests/xfs/137
> index d97942bf671a..20d46f439b8a 100755
> --- a/tests/xfs/137
> +++ b/tests/xfs/137
> @@ -12,7 +12,7 @@
>  # xfs_repair detect the problem.
>  #
>  . ./common/preamble
> -_begin_fstest auto metadata v2log
> +_begin_fstest auto metadata log
>  
>  # Import common functions.
>  
> -- 
> 2.53.0
>