Re: Should we consider disable generic/563 for file systems that do not support cgroup2?

Zorro Lang <[email protected]> Sun, 19 Jul 2026 23:57:04 +0800
Newsgroups org.kernel.vger.fstests,org.kernel.vger.linux-fsdevel
Message-ID <alzzQA9SR55FynDu@zlang-mailbox>
On Sun, Jul 19, 2026 at 10:02:47AM -0400, Theodore Tso wrote:
> On Sat, Jul 18, 2026 at 12:19:52AM -0500, Zorro Lang wrote:
> > 
> > 3. You can use or implement a _require_ function to check if a specific feature
> >    is supported, which will gracefully _notrun the test if it's missing. While
> >    _require_cgroup2() already exists, its granularity is currently too coarse to
> >    _notrun for HFS. You might want to consider refining it or introducing a new
> >    helper to help file systems like HFS+ _notrun properly.
> 
> It may be rather challenging to determine whether the file system is
> supposed to support cgroupv2, unless we want to define a VFS specific
> flag and a way to query it via sysfs.  If we want to encourage the use
> of the simpler file systems to use xfstests, we may want to consider
> that approach.

Hi Ted,

Thank you for your reply. You are right. I was just listing some possible
options, and I did not mean we must change the kernel for testing. Changing
the kernel just for a _notrun is indeed not worth it. If there is no simple
way to implement the _require_* function, we can `_exclude_fs hfs` directly :)

Thanks,
Zorro

> 
> 						- Ted
>