Re: [PATCH 2/3] xfs/65[56]: don't unset SCRATCH_RTDEV here

On Fri, Jul 10, 2026 at 07:27:34AM +0200, Christoph Hellwig wrote:
> From: "Darrick J. Wong" <[email protected]>
> 
> Both of these tests claim that they have to unset SCRATCH_RTDEV to avoid
> formatting failures due to the rt bitmap consuming all the space in the
> "small" data device.  However, the format doesn't constrain the size of
> the data device, so the justification doesn't apply.  Remove the whole
> thing.
> 
> Signed-off-by: "Darrick J. Wong" <[email protected]>
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---

Reviewed-by: Zorro Lang <[email protected]>

>  tests/xfs/655 | 4 ----
>  tests/xfs/656 | 4 ----
>  2 files changed, 8 deletions(-)
> 
> diff --git a/tests/xfs/655 b/tests/xfs/655
> index a4162d70b321..9d09cc000531 100755
> --- a/tests/xfs/655
> +++ b/tests/xfs/655
> @@ -24,10 +24,6 @@ _require_scratch_nocheck
>  _require_scratch_xfs_crc # can't detect minor corruption w/o crc
>  _require_xfs_io_command healthmon
>  
> -# Disable the scratch rt device to avoid test failures relating to the rt
> -# bitmap consuming all the free space in our small data device.
> -unset SCRATCH_RTDEV
> -
>  echo "Format and mount"
>  _scratch_mkfs -d agcount=1 | _filter_mkfs 2> $tmp.mkfs >> $seqres.full
>  . $tmp.mkfs
> diff --git a/tests/xfs/656 b/tests/xfs/656
> index c01276eb384b..5114a6c24003 100755
> --- a/tests/xfs/656
> +++ b/tests/xfs/656
> @@ -40,10 +40,6 @@ filter_healer_errors() {
>  		uniq
>  }
>  
> -# Disable the scratch rt device to avoid test failures relating to the rt
> -# bitmap consuming all the free space in our small data device.
> -unset SCRATCH_RTDEV
> -
>  echo "Format and mount"
>  _scratch_mkfs > $seqres.full 2>&1
>  _dmerror_init no_log
> -- 
> 2.53.0
>