Re: Should we consider disable generic/563 for file systems that do not support cgroup2?
Christoph Hellwig <[email protected]> Mon, 20 Jul 2026 01:07:39 -0700
| Newsgroups | org.kernel.vger.fstests,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jul 20, 2026 at 03:15:47AM +0800, Zorro Lang wrote: > Sure, hardcoding a _notrun based on FSTYP is a last resort, and it would > definitely be better if we had a more elegant way to trigger the _notrun. > As a test suite, I cannot enforce or dictate what features a specific > filesystem must export just for the convenience of testing :) Yes. And if we have to do that it should at least be in a common helper and not sprinkled over the tests. > /sys/fs/$FSTYP/features/ is indeed incredibly helpful! Just a couple of > days ago, I was actually discussing expanding _require_fs_sysfs to support > features/ checks there, since our current checks are limited to the > /sys/fs/$FSTYP/$device/ directory: > > https://lore.kernel.org/fstests/aloCfjjqesxpzL9z@zlang-mailbox/T/#mc5a0492cc00550467256951042828bef5d7fa38d features can very much depend on the actual file system instance. Trying to expose them globally doesn't make much sense.