Re: [PATCH 3/5] generic/746: skip on zoned btrfs

On Mon, Jul 27, 2026 at 11:00:35AM +0200, Johannes Thumshirn wrote:
> On Mon, Jul 20, 2026 at 10:37:38AM -0700, Christoph Hellwig wrote:
> > On Mon, Jul 20, 2026 at 01:18:47PM +0200, Johannes Thumshirn wrote:
> > > The test relies on loop device discards punching holes in the backing
> > > image file (holes are then detected via fiemap on the backing file).
> > > Zoned btrfs does not support fallocate/punch hole, so fstrim on the
> > > loop device cannot free space in the backing file and the test cannot
> > > work.
> > > 
> > > Skip the test on zoned devices, but only for btrfs so that other
> > > filesystems (e.g. zoned XFS/f2fs) can still run it.
> > 
> > This should use feature detection and not hard code file systems.
> 
> I didn't find anything for that. Only using _require_xfs_io_command
> "fpunch", but the test is not using ot so it felt wrong. 

We use _require_xfs_io_command as a shothand for feature detection
in various places, so this should be ok.

> It is not the zoned device model that prevents us but a desciccion we
> did in zoned BTRFS when doing the initial support for it. I can look
> into hole punching but I got a lot of other more urgent fires to put out
> and features people are waiting for first.


Yeah, tat should be fine.  It just did sound like a rather odd
limitation.