Re: [PATCH v2] common/rc: fix mount options quoting in _mount

On Fri, Aug 14, 2026 at 12:32:43AM +0800, Long An wrote:
> Hi Darrick,
> 
> Thank you for your comments last month. Just following up on this patch. Is
> there anything else needed from my side?

Please talk to Zorro about that, he's the fstests maintainer.

--D

> Thanks,
> An
> 
> On Thu, Jul 2, 2026 at 12:34 AM Darrick J. Wong <[email protected]> wrote:
> 
> > On Wed, Jul 01, 2026 at 02:14:07PM +0800, [email protected] wrote:
> > > From: An Long <[email protected]>
> > >
> > > In commit 078f320 ("treewide: convert all $MOUNT_PROG to _mount"),
> > > direct calls to $MOUNT_PROG were converted to call the helper function
> > > _mount.
> > > However, the _mount helper was implemented using `$*` instead of `"$@"`.
> > > This unquoted argument expansion triggers word splitting on any arguments
> > > containing spaces (such as the overlay mount options containing spaces in
> > > tests `overlay/083` and `overlay/086`), causing the mount to fail with
> > > "mount: bad usage".
> > > Fix this regression by using `"$@"` in the _mount helper, which correctly
> > > preserves argument boundaries exactly as they were provided by the
> > caller.
> > >
> > > Signed-off-by: An Long <[email protected]>
> > > ---
> > > v2: Revert the error log to "$*"
> >
> > Very good!
> > Reviewed-by: "Darrick J. Wong" <[email protected]>
> >
> > --D
> >
> > >  common/rc | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/common/rc b/common/rc
> > > index 79189e7e..b9a07324 100644
> > > --- a/common/rc
> > > +++ b/common/rc
> > > @@ -296,7 +296,7 @@ _has_dmesg_since_option()
> > >
> > >  _mount()
> > >  {
> > > -     $MOUNT_PROG $*
> > > +     $MOUNT_PROG "$@"
> > >       ret=$?
> > >       if [ "$ret" -ne 0 ]; then
> > >               echo "\"$MOUNT_PROG $*\" failed at $(date)" >>
> > "$seqres.mountfail?"
> > > --
> > > 2.51.0
> > >
> > >
> >