Re: [GSoC Patch v2 6/7] repo: add path.grafts with absolute and relative suffix formatting
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
Lucas Seiki Oshiro <[email protected]> writes: >> Introduce `path.grafts.absolute` and `path.grafts.relative` keys to >> `git repo info`. This allows scripting layers to query the active grafts >> context cleanly while scaling transparently with active `GIT_GRAFT_FILE` >> environment variable overrides. > > I ran `git repo info path.grafts.relative` in a repository with no > `grafts` file, and it returned `.git/info/grafts`, which obviously > doesn't exist. > > Wouldn't it be better if we check if that file exists before > returning this value? That is an interesting question, but I think it depends on who is querying and for what purpose. If a script is asking where to write the file, then the author wants to know where the file is supposed to be, even if no such file exists yet. Since the file format is public, they are free to write their own tools to manipulate it. Thanks.