Re: [PATCH] t0213: skip ancestry tests under user-mode emulation
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
Weijie Yuan <[email protected]> writes: >> ... >> Cc: Matthew John Cheetham <[email protected]> >> Signed-off-by: Jamie Magee <[email protected]> >> --- > > Very sorry to say something completely outside the patch. > > But may I ask what's the point of writting the line started with "Cc:"? > ... > I know that Linux kernel has something about writting Cc in the commit > message, while I don't see much from Git's documentation about trailers, > including MyFirstContribution and SubmittingPatches. If you ask me, 'Cc:' belongs in e-mail headers, not in commit messages, though the Linux kernel community has a different convention. GitGitGadget collects 'Cc:' lines from the commit message and, when sending e-mails on behalf of the author, copies the recipients listed there, if I am not mistaken. Thus, it is not surprising that contributors use the trailer for that purpose. We do not use the 'Cc:' trailer to allow a commit author to say, "As the commit object indicates, I CC'd this change to that expert. I am no longer solely responsible for any bugs in this commit. That expert should have caught my mistake!" ;-) Thanks.