Re: [PATCH] revision: make get_commit_action() a pure predicate
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
"Michael Montalbo via GitGitGadget" <[email protected]> writes: > Add a "line-log-peek" subcommand to the revision-walking test helper > that evaluates get_commit_action() on a commit the walk has not reached > yet, plus a t4211 check that the call leaves the commit's flags > unchanged. The flags are compared rather than the commit list because > add_line_range() merges ranges by union, which is idempotent, so the > side effect never changed which commits a linear -L history shows. > > Suggested-by: Junio C Hamano <[email protected]> > Signed-off-by: Michael Montalbo <[email protected]> > --- > revision: make get_commit_action() a pure predicate Sorry, but I completely lost track and I do not recall suggesting a change that amounts to 100+ lines of new lines. Are we doing any code clean-up? Bugfix? A new feature?