Re: [RFC PATCH 7/7] repack-promisor: record dropped objects in a drop log

On Fri, 24 Jul 2026 at 01:11, Siddharth Asthana
<[email protected]> wrote:
> Recording all promisor remotes for now looks OK to me with that
> NEEDSWORK. I would not block this on remote-object-info.
>
>
> > +      * is currently no way to determine that locally. it would require
> > +      * asking the remote whether it has the object. A "remote-object-info"
> > +      * command is being added to the "git cat-file --batch" protocol for
> > +      * this kind of query. Once it is merged in the codebase, this should
> > +      * record the exact promisor remote that has each dropped object.
> > +      */
> > +     for (pr = repo_promisor_remote_find(repo, NULL); pr; pr = pr->next) {
> > +             if (remotes.len)
> > +                     strbuf_addch(&remotes, ',');
> > +             strbuf_addstr(&remotes, pr->name);
> > +     }
> > +
> > +     path = repo_git_path(repo, "objects/info/promisor-dropped");
>
>
> If we keep it, it would be nice to document this path (for example in
> gitrepository-layout) and to have a small test that a real drop appends
> a line.

sounds good, when the log is finalized, whether as a min.  version now
or alongside the
error-path change later, I can document objects/info/promisor-dropped in
gitrepository-layout then

Thanks,
Siddharth Shrimali